STORM-3066: Implement support for using list elements in properties in FluxParser#3155
Merged
Conversation
srdo
reviewed
Oct 28, 2019
Contributor
srdo
left a comment
srdo
left a comment
There was a problem hiding this comment.
Looks great, left a few comments for your consideration
| LOG.info("Performing property substitution."); | ||
| for (Object key : properties.keySet()) { | ||
| str = str.replace("${" + key + "}", properties.getProperty((String)key)); | ||
| reader.lines().forEach(line -> { |
Contributor
There was a problem hiding this comment.
This is minor, but I'm wondering if this could be made slightly easier to read using .map and .collect along with the joining Collector https://docs.oracle.com/javase/8/docs/api/java/util/stream/Collectors.html#joining--
That way you wouldn't have to add the new line to the StringBuilder manually, and there'd be less to do in the else-cases where things aren't matched.
Author
There was a problem hiding this comment.
Thanks for the suggestion. Better now I think. Can you take a look? 🙇
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR adds support for accessing elements of list properties in configurations of FluxParser.
The reference of list items can be done as:
Additionally, refactors the code a bit more efficient and lighter on memory.