MINOR: create a checklist for testing a new Storm release#3161
Merged
Conversation
Ethanlm
force-pushed
the
update-release-doc-2
branch
from
9258256 to
459cd58
Compare
Ethanlm
force-pushed
the
update-release-doc-2
branch
from
459cd58 to
b01bc8e
Compare
srdo
reviewed
Oct 30, 2019
| Below is a checklist that one could do to review a release candidate. | ||
| Please note this list is not exhaustive and only includes some of the common steps. Feel free to add your own tests. | ||
|
|
||
| 1. Verify files such as *.asc, *.sha512; |
Contributor
There was a problem hiding this comment.
I think we should link to the utility script in dev-tools/rc for this. I didn't know about it until I happened across it recently, would be good to raise visibility.
Contributor
Author
There was a problem hiding this comment.
I think the original order is fine. We need to have release candidate then we can review and vote. It's more natural to me
Contributor
There was a problem hiding this comment.
I think your comments got switched somehow.
Ok, it's fine. I'd just like this guidance to be visible to people.
|
|
||
| 3. Delete the git tag. | ||
|
|
||
| # How to vote on a release candidate |
Contributor
There was a problem hiding this comment.
I'm wondering if this belongs at the top of the file? The audience for it is probably broader than the audience for how to author a release.
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a checklist so new devs have a better idea on reviewing a release