[STORM-3584] Support getting version info from a wildcard classpath entry#3211
Merged
Ethanlm merged 2 commits intoapache:masterfrom Feb 24, 2020
Merged
[STORM-3584] Support getting version info from a wildcard classpath entry#3211Ethanlm merged 2 commits intoapache:masterfrom
Ethanlm merged 2 commits intoapache:masterfrom
Conversation
Ethanlm
commented
Feb 21, 2020
| List<String> children = new ArrayList<>(); | ||
| Files.list(parent).forEach(path -> children.add(path.toString())); | ||
| Files.list(parent) | ||
| //avoid infinite recursion |
Contributor
Author
There was a problem hiding this comment.
infinite recursion can happen if there is a file named * under /<parent-path>/ directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/STORM-3584
Current VersionInfo.getFromClasspath method only tries to get version info from the specific property file under a directory, or jar/zip files. It should support a classpath entry like
/<parent-path>/*.