[STORM-3589] Prevent inconsistent results from consecutive hasNext and next calls in LazyNodeSortingIterator#3216
Merged
Ethanlm merged 1 commit intoapache:masterfrom Feb 27, 2020
Merged
Conversation
Contributor
|
Good catch. But I think there is a bug in this code: first assume if every node is in the |
2b5ecd0 to
f99992c
Compare
Contributor
Author
|
@Ethanlm Wow sorry for overlook this. Thanks for pointing out. Fixed and force pushed. |
…d next calls in LazyNodeSortingIterator
f99992c to
2b6b5cd
Compare
Ethanlm
approved these changes
Feb 26, 2020
Contributor
Ethanlm
left a comment
There was a problem hiding this comment.
+1 Thanks for the quick fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent the problem that consecutive hasNext() calls will lose elements in nodeIterator without using it.
Prevent the problem that consecutive next() calls will skip to post iterator since nextValueFromNode is null even if nodeIterator still have available elements.