[STORM-2483] misnamed parameters#3229
Merged
Ethanlm merged 1 commit intoapache:masterfrom Mar 19, 2020
nd368:STORM-2483
Merged
Conversation
Ethanlm
approved these changes
Mar 17, 2020
Contributor
Ethanlm
left a comment
Ethanlm
left a comment
There was a problem hiding this comment.
+1
Can't believe this has been wrong for so long.
Could you please also file a PR against 1.x-branch https://github.com/apache/storm/tree/1.x-branch?
Thanks
Contributor
Author
|
hi Ethan, have done so - how many travis CI checks need to pass for 1.x branch build to be considered successful? 🤔 |
Contributor
|
Thanks. I believe 1.x-branch build is flaky. Rekicked it off again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all 15 usages of method were already sending in componentId as first argument, streamId as second argument - so only naming inside of method needed to be changed