STORM-248 STORM-322 proposal for fix #353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for org.apache.hadoop.io.serializer.Serialization to the SequenceFileBolt. The new SerializableSequenceFormat interface allows serialization systems like Avro to be plugged into the SequenceFileBolt.
Contributor
|
+1 the changes look fine to me. Please upmerge. the storm python script has changed since you did the pull request and there are some minor merge conflicts that should be simple to fix. |
Contributor
Author
|
Rebased and resolved conflicts from upstream/master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details are in JIRA https://issues.apache.org/jira/browse/STORM-248.
As a collateral benefit, this also addresses JIRA https://issues.apache.org/jira/browse/STORM-322.
Could you please review ?