Skip to content

Conversation

@l03wn3
Copy link

@l03wn3 l03wn3 commented Apr 7, 2015

https://issues.apache.org/jira/browse/STORM-759

It would be really nice if there was a storm target like "jar", but one that would pause and wait for a remote java debugger so you could debug your topology while running locally.
Incidentally, here's a more or less trivial fix for this.

@Parth-Brahmbhatt
Copy link
Contributor

you could just use the storm jar command and provide the debug args as topology.worker.childopts config. I don't think we need a special command for this.

@l03wn3
Copy link
Author

l03wn3 commented Apr 7, 2015

Doing
Config conf = new Config();
conf.put(Config.TOPOLOGY_WORKER_CHILDOPTS, "-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005");

Doesn't make the JVM suspend upon start and wait for a debugger. Would there be another convenient way?

@HeartSaVioR
Copy link
Contributor

@Parth-Brahmbhatt
Maybe @l03wn3 want to attach debugger with main process which submits topology, not deployed workers. But still I agree it doesn't need to add special command.

@l03wn3
If I know "storm.py" right, for now you can try adding your arguments to system environment STORM_JAR_JVM_OPTS before executing "storm jar".
Sure you can restore STORM_JAR_JVM_OPTS after doing this.

@Parth-Brahmbhatt
Copy link
Contributor

in that case you are right , if you want to test in local mode you should use STORM_JAR_JVM_OPTS.

@lazyval
Copy link
Contributor

lazyval commented Apr 8, 2015

@Parth-Brahmbhatt +1

@d2r
Copy link

d2r commented Dec 28, 2015

@l03wn3, is STORM_JAR_JVM_OPTS OK for debugging this way?

If so, would you close this pull request? Otherwise, would you create a Jira issue for this change?

@knusbaum
Copy link
Contributor

Closing this. Please reopen if it's still an issue.

@asfgit asfgit closed this in fdac5bb Aug 23, 2016
leedohyun added a commit to leedohyun/storm that referenced this pull request Aug 24, 2016
* upstream/master: (26 commits)
  closes apache#494
  closes apache#534
  closes apache#478
  closes apache#510
  closes apache#471
  closes apache#346
  add STORM-2016 to CHANGELOG
  STORM-2016 Topology submission improvement: support adding local jars and maven artifacts on submission
  add STORM-2047 to CHANGELOG
  add dummy whitespace to retrigger github mirror sync processor
  add Juan Paulo Gutierrez to contributor list
  add Arthur Maciejewicz to contributors
  add Dohyun Lee to contributor
  fix code in KafkaSpoutRetryExponentialBackoff in storm-kafka-client
  add STORM-2045 to CHANGELOG
  add STORM-1994 to CHANGELOG
  [STORM-2047] Add note to add logviewer hosts to browser whitelist
  Fixed log message for credential renewal.
  add STORM-2042 to CHANGELOG
  add STORM-2041 to CHANGELOG
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants