Skip to content

Add a convenience target to use when debugging topologies locally #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add a convenience target to use when debugging topologies locally #510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion bin/storm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ def init_storm_env():
CONFIG_OPTS = []
CONFFILE = ""
JAR_JVM_OPTS = shlex.split(os.getenv('STORM_JAR_JVM_OPTS', ''))
JAR_DEBUG_JVM_OPTS = '-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005'
JAVA_HOME = os.getenv('JAVA_HOME', None)
JAVA_CMD = 'java' if not JAVA_HOME else os.path.join(JAVA_HOME, 'bin', 'java')

Expand Down Expand Up @@ -206,6 +207,27 @@ def jar(jarfile, klass, *args):
args=args,
jvmopts=JAR_JVM_OPTS + ["-Dstorm.jar=" + jarfile])

def jardebug(jarfile, klass, *args):
"""Syntax: [storm jardebug topology-jar-path class ...]

Will start the main method of class with specified arguments, and then
suspend the JVM, waiting for a remote debugger to connect.
Convenient for debugging your storm topologies.

Otherwise works as the jar target.

The storm jars and configs in ~/.storm are put on the classpath.
The process is configured so that StormSubmitter
(http://storm.incubator.apache.org/apidocs/backtype/storm/StormSubmitter.html)
will upload the jar at topology-jar-path when the topology is submitted.
"""
exec_storm_class(
klass,
jvmtype="-client",
extrajars=[jarfile, USER_CONF_DIR, STORM_BIN_DIR],
args=args,
jvmopts=JAR_JVM_OPTS + ["-Dstorm.jar=" + jarfile] + [JAR_DEBUG_JVM_OPTS])

def kill(*args):
"""Syntax: [storm kill topology-name [-w wait-time-secs]]

Expand Down Expand Up @@ -497,7 +519,7 @@ def unknown_command(*args):
print_usage()
sys.exit(254)

COMMANDS = {"jar": jar, "kill": kill, "shell": shell, "nimbus": nimbus, "ui": ui, "logviewer": logviewer,
COMMANDS = {"jar": jar, "jardebug": jardebug, "kill": kill, "shell": shell, "nimbus": nimbus, "ui": ui, "logviewer": logviewer,
"drpc": drpc, "supervisor": supervisor, "localconfvalue": print_localconfvalue,
"remoteconfvalue": print_remoteconfvalue, "repl": repl, "classpath": print_classpath,
"activate": activate, "deactivate": deactivate, "rebalance": rebalance, "help": print_usage,
Expand Down