STORM-866: Use storm.log.dir instead of storm.home in log4j2 config #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It would be better to remove following "/logs" from all of your changeset since storm.log.dir already points that directory. |
Author
|
@HeartSaVioR Thanks for your advice, I just committed another patch. |
Contributor
|
@tedxia LGTM. Great for finding missed spot! |
Contributor
|
LGTM. +1 |
Contributor
|
I'd like to include this into 0.10.x-branch since it's a bug, and we're having a chance to fix it before releasing stable version. |
Contributor
|
Merged into 0.10.x-branch, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for STORM-866
The config log4j2 use storm.home as log dir, but not storm.log.dir, we should use storm.log.dir instead.