Fix NPE in getSupervisorPageInfo for unknown hostnames#8442
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rzo1
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a
NullPointerExceptioninNimbus.getSupervisorPageInfo()when querying by a hostname with no supervisor registered in the cluster.Bug
getSupervisorPageInfois called by the Storm UI's/api/v1/supervisorendpoint. WhensuperIdis null (query by hostname),hostToSuperId.get(host)returnsnullfor unknown hosts. The subsequent for-each loop dereferences it:This is easily triggered by bookmarked URLs for decommissioned supervisors or hostname typos.
Fix
Guard against null with Collections.emptyList(), returning an empty SupervisorPageInfo instead of crashing
🤖 Generated with Claude Code