Skip to content

Conversation

@knusbaum
Copy link
Contributor

@HeartSaVioR
Copy link
Contributor

@knusbaum
It makes build slower than current now. Please refer #761 for more info.

Btw, if it is more stable than legacy (I mean less random test failures) I'll definitely vote +1.

Testing

Testing

Testing

Testing

Testing

Testing

Testing

Fixing .travis.yml
@knusbaum
Copy link
Contributor Author

@HeartSaVioR

There. I shaved a little more than 5 minutes off the build time.

@HeartSaVioR
Copy link
Contributor

@knusbaum
Container based build doesn't save build time.
Seems like splitting build matrix saves build time, so I'd like to see it applied to legacy.

Btw, container based build is triggered faster than legacy, so container based build takes advantage when build time is small enough.

@knusbaum knusbaum closed this Nov 11, 2015
@knusbaum knusbaum deleted the STORM-1197 branch November 11, 2015 01:35
@HeartSaVioR
Copy link
Contributor

@knusbaum
Hey, I see the benefit of splitting build matrix, since it seems faster than current.
If legacy + splitting build matrix doesn't work, I'd like to vote +1 to container based + splitting build matrix.
I'd like to see reason of closing this PR. Did you see the disadvantage of splitting build matrix?

@knusbaum
Copy link
Contributor Author

@HeartSaVioR
Yes, I remembered that the external parts I split off the storm-core build are dependent on the storm-core jar, so they must be done after storm-core. There isn't any benefit to doing the external, etc. in parallel with each other either, since they are so small that the startup cost overwhelms the parallelization benefit.

The caching is still valid, but it only shaves a few seconds off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants