Skip to content

Conversation

@zhuoliu
Copy link

@zhuoliu zhuoliu commented Jan 8, 2016

Using DirectoryStream to replace File.listFiles will save logviewer memory usage since it does not require loading all files' metadata into memory. This avoids potential memory usage problem in extreme case (e.g., you have millions of small files in your log directory).
Also, a multi-phase PQ-based sorting and cleaning scheme is introduced in DirectoryCleaner for replacing the global in-memory sorting.

@revans2
Copy link
Contributor

revans2 commented Jan 11, 2016

These changes look rather large, but the tests pass and the code looks good. I assume you have done some manual testing so I am +1.

@asfgit asfgit merged commit 7cc1d05 into apache:master Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants