Replace Thread.sleep polling with Awaitility in tests#1852
Merged
Conversation
Replaces manual while/Thread.sleep polling patterns with Awaitility's await().atMost().until() across 9 test files in core, solr, opensearch, urlfrontier, and playwright modules. Centralizes the awaitility version in the parent POM's dependencyManagement and adds the dependency to modules that were missing it (solr, opensearch, urlfrontier). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Julien Nioche <julien@digitalpebble.com>
rzo1
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
while/Thread.sleeppolling loops with Awaitility'sawait().atMost().until()across 9 test files in core, solr, opensearch, urlfrontier, and playwright modulesawaitilityversion (4.3.0) in the parent POM'sdependencyManagement, removing duplicated version declarations from child modulesawaitilitytest dependency to solr, opensearch, and urlfrontier modules which were missing itTest plan
mvn install -DskipTestssucceeds (confirmed locally)🤖 Generated with Claude Code