Resolve issue #32 - implement cookie handeling#449
Conversation
|
I still see the formatting issues, as I suspected - they are caused by the formatter plugin, when I run it it changes formatting in all files. Might it be related to the fact I'm running on windows? When I do a diff using "ignore whitespaces" I just see the changed lines, as it should be. |
|
thanks @foromer4, will apply the formatting in a separate commit. I'll also add a conf file to the repo to specify that we want line endings to be linux style. I hadn't realised that the Eclipse formatting rules did not cover that at all. See https://help.github.com/articles/dealing-with-line-endings/#platform-all Thanks again for your contribution and your patience |
|
thank you @jnioche for your help and guidance - hopefully next time would go smoother |
OK , trying again, with all requested adjustments.