Skip to content

Resolve issue #32 - implement cookie handeling#449

Merged
jnioche merged 1 commit intoapache:masterfrom
foromer4:master
Mar 30, 2017
Merged

Resolve issue #32 - implement cookie handeling#449
jnioche merged 1 commit intoapache:masterfrom
foromer4:master

Conversation

@foromer4
Copy link
Copy Markdown

@foromer4 foromer4 commented Mar 30, 2017

OK , trying again, with all requested adjustments.

@foromer4
Copy link
Copy Markdown
Author

foromer4 commented Mar 30, 2017

I still see the formatting issues, as I suspected - they are caused by the formatter plugin, when I run it it changes formatting in all files.
I just commit the 4 changed files, but they too are formatted in a way that the dif tools don't understand.

Might it be related to the fact I'm running on windows?
some issue like this one maybe?

When I do a diff using "ignore whitespaces" I just see the changed lines, as it should be.

@jnioche jnioche merged commit aad6e16 into apache:master Mar 30, 2017
@jnioche jnioche added this to the 1.5 milestone Mar 30, 2017
@jnioche
Copy link
Copy Markdown
Contributor

jnioche commented Mar 30, 2017

thanks @foromer4, will apply the formatting in a separate commit.

I'll also add a conf file to the repo to specify that we want line endings to be linux style. I hadn't realised that the Eclipse formatting rules did not cover that at all. See https://help.github.com/articles/dealing-with-line-endings/#platform-all

Thanks again for your contribution and your patience

@foromer4
Copy link
Copy Markdown
Author

thank you @jnioche for your help and guidance - hopefully next time would go smoother

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants