This repository was archived by the owner on May 12, 2021. It is now read-only.
Refactoring REST API #288
Closed
Refactoring REST API #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @anuruddhal for the fixes, as I can see there are merge conflicts in this pull request now. Would you mind resolving them? |
…directly in Cluster Monitor
…o terminate instances
…CC service invocation
…hange the error message to a specific one
Conflicts: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41.java components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Changes were done.
Catch specific/custom exception - customize the log messages according to exception type (addCartridge(), updateCartridge() etc.)
getAvailableCartridges() - remove obsolete code & simplify
Remove obsolete code related to billing
getCartridgesByFilter() remove hard-coded strings
Change method parameters to primitive boolean
Refactor isAlreadySubscribed() method
Add missing method comments
Refactor validateDeploymentPolicy(), getApplicationRuntime(), getApplicationSignUps()
Make private static log to be final
Rename StratosUserManager as a util class and make the methods static