This repository was archived by the owner on May 12, 2021. It is now read-only.
Fixed deactivating non-exist tenant in cli #329
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Is this a specific exception? Or an internal issue?
If it is not an internal issue, we should not throw RestAPIException.
Contributor
Author
|
I have fixed both tenant activate and deactivate cli issues. Please review and merge. |
Contributor
|
Thanks Pubudu! I have now merged this to master branch, please close the pull request manually. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed deactivating non-exist tenant in cli. In the current implementation it doesn't check for the existence of the tenant. Tenant id becomes -1 for non exist tenant.