This repository was archived by the owner on May 12, 2021. It is now read-only.
Fixed issues found when removing a non existing cartridge#353
Closed
dinithis wants to merge 19 commits intoapache:masterfrom
dinithis:master
Closed
Fixed issues found when removing a non existing cartridge#353dinithis wants to merge 19 commits intoapache:masterfrom dinithis:master
dinithis wants to merge 19 commits intoapache:masterfrom
dinithis:master
Conversation
Contributor
There was a problem hiding this comment.
We should not catch the specific exception at Util class. Catch it in API class and send the response code accordingly.
Contributor
Author
There was a problem hiding this comment.
I have corrected this with the commit "handling specific exceptions in API class"
Contributor
There was a problem hiding this comment.
Let's not send BAD_REQUEST for Remote exception. We can throw a RestAPIException for that, since it will be an internal server error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issues found when removing a non existing cartridge