This repository was archived by the owner on May 12, 2021. It is now read-only.
Review changes #82
Closed
Review changes #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
raj-rajaratnam
commented
Oct 7, 2014
raj-rajaratnam
commented
- changing log.fatal() to log.warn()
- custom message to log.error(msg, e)
- license header to difference.rb in puppet module
- made obsoleted member expiry time configurable
- log.warn() when cluster monitor creation failed
- changing log.debug() to log.error() when cluster monitor not found, while receiving topology and health stats events
Contributor
There was a problem hiding this comment.
Seems like we have a spelling mistake here: "obsoltedMemberExpiryTimeout"
Contributor
Author
There was a problem hiding this comment.
This is fixed now. Thanks Imesh for pointing this out.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.