This repository was archived by the owner on May 12, 2021. It is now read-only.
Re-factoring of the meta data service #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asfgit
pushed a commit
that referenced
this pull request
Oct 9, 2014
…unarathne/stratos into 4.0.0-grouping This closes #84
There was a problem hiding this comment.
adding more information to this would be helpful I suppose.
There was a problem hiding this comment.
I don't see we check isDebugEnabled here, but we can that down the line for a another log entry. is that intentional?
Contributor
Author
There was a problem hiding this comment.
Thanks Ramith for pointing this.As a convention, I think we can check isDebugEnabled.As there is no String concatenation I guess it didn't check there.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following
1.Meta data service code re-factoring
2.Meta data service configuration changes