Conversation
bossenti
approved these changes
Jan 18, 2023
| dataCy: string; | ||
|
|
||
| @Input() | ||
| isChecked = false; |
Member
There was a problem hiding this comment.
What is the default behaviour? Adapters are started upon creation?
Member
There was a problem hiding this comment.
Ok, I see that startAdapterNow is true. Why is isChecked initially set to false?
Contributor
Author
There was a problem hiding this comment.
The default value is false only for the AdapterOptionsPanel component. This component is also used for other configurations like Remove Duplicate. Since the default value for all other configurations is false, I decided to set the default value of this component to false as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix #1114. Adapters can now be added without having to be started.
This PR also includes a fix for the FileStreamAdapter. When the adapter is stopped, the running replays are now interrupted.
Remarks
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no