Conversation
tenthe
left a comment
tenthe
left a comment
There was a problem hiding this comment.
I like the changes and I totally agree, we should further simplify this API. This is a good step into this direction.
Maybe we can also delete DataLakeMeasureResourceV3 & DataLakeResourceV3 since it is now deprecated for some time.
There was a problem hiding this comment.
The wildcard import should be removed
bossenti
left a comment
bossenti
left a comment
There was a problem hiding this comment.
@dominikriemer great work! As far as I can see, this is a great simplification.
I have only roughly skimmed the changes, as I am not yet very deep into this part of StreamPipes
But the general impression is pretty good!
If you want a more detailed review, I'm happy to dig a little deeper.
There was a problem hiding this comment.
Can we rely on time being always the first header?
3 participants
Purpose
Fix bug where the data download dialog ignored query-specific settings when selecting "download current query".
In addition, this PR improves code structure by extracting all download-specific features from the DataLakeManagementV4 class into smaller classes and deletes obsolete and unused classes.
The module needs more refactoring though.
Approach
Samples
Remarks
Fixes: