Skip to content

Add implementation for schema guessing from the example file in the HTTP Server source. #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
obermeier wants to merge 2 commits into from
Closed

Add implementation for schema guessing from the example file in the HTTP Server source. #1638

obermeier wants to merge 2 commits into from

Conversation

@obermeier
Copy link
Member

@obermeier obermeier commented May 30, 2023

resolves #1637
fixes #1518 for streampipes-extensions

PR introduces (a) breaking change(s):
PR introduces (a) deprecation(s):

@github-actions github-actions bot added backend Everything that is related to the StreamPipes backend connect Related to the `connect` module (adapters) dependencies Pull requests that update a dependency file java Pull requests that update Java code labels May 30, 2023
@bossenti bossenti mentioned this pull request May 30, 2023
Merged
@obermeier obermeier removed the dependencies Pull requests that update a dependency file label May 31, 2023
@tenthe
Copy link
Contributor

tenthe commented May 31, 2023

Hi @obermeier,
thank you very much for the PR.
It looks good, I was just wondering if we can add these changes directly to the remove-set-adapters branch.
There we have changed the API quite a bit and I suspect we will get a merge conflict. The branch will be merged into dev soon anyway.

[1] https://github.com/apache/streampipes/tree/remove-set-adapters

@obermeier
Copy link
Member Author

obermeier commented Jun 1, 2023

Hi @tenthe,

thank you for this hint.
I pushed it 1cb22eb

@obermeier obermeier closed this Jun 1, 2023
@obermeier obermeier deleted the obermeier/dev branch June 1, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tenthe tenthe tenthe approved these changes

@bossenti bossenti bossenti approved these changes

Assignees

No one assigned

Labels

backend Everything that is related to the StreamPipes backend connect Related to the `connect` module (adapters) java Pull requests that update Java code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Schema guessing from file is currently not implemented in HTTP Server source Compiling maven submodule with checkstyle check

3 participants

@obermeier @tenthe @bossenti