1662 support asynchronous browsing in opc ua adapter#1675
Merged
dominikriemer merged 9 commits intodevfrom Jun 14, 2023
Merged
Conversation
github-actions
bot
added
backend
github-actions
bot
removed
the
connect
tenthe
reviewed
Jun 13, 2023
Contributor
tenthe
left a comment
tenthe
left a comment
There was a problem hiding this comment.
Hey, thanks a lot for providing the feature. This is really cool. I had two minor comments regarding the code. Once they are resolved I will approve the PR.
Cheers,
Philipp
...ache/streampipes/extensions/connectors/opcua/adapter/configuration/SpOpcUaConfigBuilder.java
Outdated
Show resolved
Hide resolved
...ore-ui/static-properties/static-runtime-resolvable-tree-input/static-tree-input.component.ts
Outdated
Show resolved
Hide resolved
tenthe
approved these changes
Jun 13, 2023
bossenti
added
the
breaking change
Contributor
can we have a short description on how to achieve this or (even better) provide a link to the documentation? |
bossenti
reviewed
Jun 13, 2023
...main/java/org/apache/streampipes/sdk/builder/AbstractConfigurablePipelineElementBuilder.java
Show resolved
Hide resolved
...a/src/main/java/org/apache/streampipes/extensions/connectors/opcua/adapter/OpcUaAdapter.java
Show resolved
Hide resolved
...e-ui/static-properties/static-runtime-resolvable-tree-input/static-tree-input.component.html
Show resolved
Hide resolved
...c/main/java/org/apache/streampipes/extensions/connectors/opcua/adapter/OpcUaNodeBrowser.java
Show resolved
Hide resolved
dominikriemer
deleted the
1662-support-asynchronous-browsing-in-opc-ua-adapter
branch
1 task
jjbiggins
pushed a commit
to jjbiggins/streampipes
that referenced
this pull request
Jul 5, 2023
* Support asynchronous browsing in OPC adapter (apache#1662) * Improve validation of completed static properties (apache#1662) * Update Milo version, add more metadata (apache#1662) * Improve formatting * Fix validation of tree input * Remove obsolete keys from strings file * Cleanup OPC UA config classes
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Improves OPC-UA browsing in te OPC-UA adapter (see #1662)
Remarks
PR introduces (a) breaking change(s): yes
Requires update of the OPC-UA adapter model
PR introduces (a) deprecation(s): no