Skip to content

Conversation

@dominikriemer
Copy link
Member

Purpose

Improve the handling of data lake measures when using the API:

  • Keep document ID if present
  • Return 404 if the requested measure is not present

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@github-actions github-actions bot added java Pull requests that update Java code backend Everything that is related to the StreamPipes backend labels Jul 10, 2023
@bossenti
Copy link
Contributor

@dominikriemer is there a need to account for this changes in the Python client?

@dominikriemer
Copy link
Member Author

@dominikriemer is there a need to account for this changes in the Python client?

I had a brief look and I don't think so - can you please double-check if it's ok? The Java client had the issue that it tried to deserialize the empty response.

@dominikriemer dominikriemer merged commit 971d9d9 into dev Jul 10, 2023
@dominikriemer dominikriemer deleted the fix-id-handling-of-data-lake-measures branch July 10, 2023 16:08
@bossenti
Copy link
Contributor

@dominikriemer is there a need to account for this changes in the Python client?

I had a brief look and I don't think so - can you please double-check if it's ok? The Java client had the issue that it tried to deserialize the empty response.

Should be fine I guess :)

@tenthe time to work together on #774 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Everything that is related to the StreamPipes backend java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants