[#1895]Implement unit tests for pipeline element 'MergeByTimeProcessor'

[rahulbiswas876]

#

Purpose

see 1895

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

[bossenti]

Thanks a lot for your contribution @rahulbiswas876 🙏🏼

[rahulbiswas876]

This is my first open source PR. I really enjoyed and learned while implementing the unit test how actually a good software code is written. Thanks team and @bossenti reviewing the PR.

I am open to learn and excel. Please do let me know how I can improve my contributions.

[bossenti]

There are some checkstyle issues (formatting issues): https://github.com/apache/streampipes/actions/runs/6504978848/job/17668735199?pr=2023#step:4:69572

[rahulbiswas876]

There are some checkstyle issues (formatting issues): https://github.com/apache/streampipes/actions/runs/6504978848/job/17668735199?pr=2023#step:4:69572

can you please guide me which code style you guys follow.. Currently I am following GoogleStyle

[rahulbiswas876]

There are some checkstyle issues (formatting issues): https://github.com/apache/streampipes/actions/runs/6504978848/job/17668735199?pr=2023#step:4:69572

fixed the check-style violations.

[bossenti]

There are some checkstyle issues (formatting issues): https://github.com/apache/streampipes/actions/runs/6504978848/job/17668735199?pr=2023#step:4:69572

can you please guide me which code style you guys follow.. Currently I am following GoogleStyle

You can find our checkstyle config here

[bossenti]

Would probably be worth to mention somewhere in the documentation 🙈

[rahulbiswas876]

@bossenti can you please re-review the PR

[bossenti]

Hey @rahulbiswas876,

I really appreciate your motivation to contribute.
Please keep in mind that we are a community of volunteers trying to support and improve StreamPipes as much as possible. However, we all contribute to this project in our spare time. Therefore, it may take some time before we are able to respond to requests. This includes PR reviews. We won't forget about your PR, even if it might take us a few days to respond to updates.
I was pretty responsive this morning, but that can't be taken for granted.

[bossenti]

Can you please add a directory called java between test and org?
This allows the file to be recognized as a test case

[rahulbiswas876]

Hey @rahulbiswas876,

I really appreciate your motivation to contribute. Please keep in mind that we are a community of volunteers trying to support and improve StreamPipes as much as possible. However, we all contribute to this project in our spare time. Therefore, it may take some time before we are able to respond to requests. This includes PR reviews. We won't forget about your PR, even if it might take us a few days to respond to updates. I was pretty responsive this morning, but that can't be taken for granted.

Hey @bossenti,

Since it is my 1st open source PR after struggling over the week to set up dev env and then learning git and all, I was overexcited and eager to get merged 🙈

But Yes, I acknowledge your feedback and thank the community for giving me the opportunity to learn and share openly.

[bossenti]

I was overexcited and eager to get merged

Keep that spirit @rahulbiswas876!
Just wanted to manage expectations 🙂