Skip to content

Enable checkstyle for streampipes-messaging-* modules#827

Merged
dominikriemer merged 13 commits into
devfrom
SP-820
Dec 2, 2022
Merged

Enable checkstyle for streampipes-messaging-* modules#827
dominikriemer merged 13 commits into
devfrom
SP-820

Conversation

@dominikriemer
Copy link
Copy Markdown
Member

Purpose

Approach

Samples

Remarks

Fixes:

@dominikriemer
Copy link
Copy Markdown
Member Author

@RobertIndie @tenthe I deactivated the NewlineAtEndOfFile rule as this caused problems on windows and proper line ending conversion between LF and CRLF should be ensured by Git. Is this ok?

@dominikriemer dominikriemer marked this pull request as ready for review December 1, 2022 21:53
@RobertIndie
Copy link
Copy Markdown
Member

Hi @dominikriemer

I deactivated the NewlineAtEndOfFile rule as this caused problems on windows and proper line ending conversion between LF and CRLF should be ensured by Git. Is this ok?

I am okay with that. It should be controlled by the git.

@tenthe
Copy link
Copy Markdown
Contributor

tenthe commented Dec 2, 2022

@dominikriemer I think that should be fine.
The main intention of this rule is to make it easier for others and diff tools to add and track changes as it is described in [1].
I would say it is more important to have an approach that works on all development machines regardless of the operating system.

[1] https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheck.html

@dominikriemer dominikriemer merged commit 35d55fa into dev Dec 2, 2022
@dominikriemer dominikriemer deleted the SP-820 branch December 2, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants