WW-4291: Allow Spring bean names for type converters (6.9.x backport)#1564
Merged
lukaszlenart merged 1 commit intorelease/struts-6-8-xfrom Feb 6, 2026
Merged
Conversation
Implement two-phase processing for conversion properties to enable Spring bean name resolution in struts-conversion.properties files. The issue was a timing problem: type converters were processed during bootstrap phase before SpringObjectFactory was available. Now: - Early phase: process struts-default-conversion.properties (class names) - Late phase: process user properties when SpringObjectFactory is ready Changes: - Add UserConversionPropertiesProvider interface for late initialization - Add UserConversionPropertiesProcessor to trigger late phase processing - Split StrutsConversionPropertiesProcessor.init() into early/late phases - Register new beans in DefaultConfiguration and struts-beans.xml - Add alias in StrutsBeanSelectionProvider for dependency injection - Improve JavaDocs for BeanSelectionProvider classes Closes WW-4291 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
lukaszlenart
requested review from
aleksandr-m,
cnenning,
jogep,
kusalk,
rgielen,
sdutry and
yasserzamani
lukaszlenart
changed the title
|
lukaszlenart
deleted the
feat/WW-4291-spring-bean-type-converters-6.8.x
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of PR #1562 to the
release/struts-6-8-xbranch.e0d26837028fd44a227863e27f813c66386e3bf6frommainstruts-conversion.propertiesfiles instead of only fully qualified class namesChanges
UserConversionPropertiesProcessorfor late initializationUserConversionPropertiesProviderinterfaceStrutsConversionPropertiesProcessorfor two-phase processingDefaultConfigurationto trigger late initializationConflicts Resolved
com.opensymphony.xwork2vsorg.apache.struts2)@sincetags updated to6.9.0Test plan
StrutsConversionPropertiesProcessorTestpassesSpringTypeConverterTestpassesFixes WW-4291
🤖 Generated with Claude Code