WW-5535: enforce HTTP method annotations for wildcard actions#1593
Open
lukaszlenart wants to merge 1 commit intorelease/struts-6-8-xfrom
Open
WW-5535: enforce HTTP method annotations for wildcard actions#1593lukaszlenart wants to merge 1 commit intorelease/struts-6-8-xfrom
lukaszlenart wants to merge 1 commit intorelease/struts-6-8-xfrom
Conversation
DefaultActionProxy.resolveMethod() incorrectly set methodSpecified=false for config-resolved methods (including wildcard-substituted ones), causing HttpMethodInterceptor to skip method-level @HttpPost/@httpget annotation checks. Move methodSpecified=false inside the inner if block so it only applies when truly defaulting to "execute". 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
lukaszlenart
requested review from
aleksandr-m,
cnenning,
jogep,
kusalk,
rgielen,
sdutry and
yasserzamani
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultActionProxy.resolveMethod()to only setmethodSpecified=falsewhen truly defaulting to"execute", not when the method is resolved from action config (including wildcard substitution likemethod="{1}")HttpMethodInterceptorchecks method-level@HttpPost/@HttpGetannotations for wildcard-resolved actionsTest plan
DefaultActionProxyTest— 4 new tests covering explicit method, config-resolved method, execute default, and wildcard resolutionHttpMethodInterceptorTest— 2 new tests verifying wildcard-resolved methods respect@HttpPostannotationsXmlConfigurationProviderAllowedMethodsTest— updated assertion for 3 new action configs🤖 Generated with Claude Code