Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

Conversation

@cdmikechen
Copy link
Contributor

What is this PR for?

The operator-v3 based custom resource already supports automatic secret generation without the database password, so we don't need this config to be required.

What type of PR is it?

Bug Fix

Todos

  • - Remove mysqlRootPasswordSecret required

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1375

How should this be tested?

NA

Screenshots (if appropriate)

NA

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #1059 (25d5da9) into master (5987b92) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1059   +/-   ##
=======================================
  Coverage   75.98%   75.98%           
=======================================
  Files         119      119           
  Lines        5000     5000           
=======================================
  Hits         3799     3799           
  Misses       1201     1201           
Flag Coverage Δ
python-integration 59.72% <ø> (ø)
python-unit 52.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@asfgit asfgit closed this in 1783097 Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant