Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-1141. Create experiment image dropdown list UI improvement#1087

Merged
pingsutw merged 1 commit intoapache:masterfrom
cdmikechen:SUBMARINE-1141
Jul 20, 2023
Merged

SUBMARINE-1141. Create experiment image dropdown list UI improvement#1087
pingsutw merged 1 commit intoapache:masterfrom
cdmikechen:SUBMARINE-1141

Conversation

@cdmikechen
Copy link
Copy Markdown
Contributor

What is this PR for?

Fix dropdown bug

What type of PR is it?

Bug Fix

Todos

  • - Fix the displayed bug
  • - Avoid duplicates or empties in dropdown list

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1141

How should this be tested?

See screenshot

Screenshots (if appropriate)

Before:
image

After:
image

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 15, 2023

Codecov Report

Merging #1087 (ba55238) into master (b0d96b3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1087   +/-   ##
=======================================
  Coverage   67.27%   67.27%           
=======================================
  Files         128      128           
  Lines        6224     6224           
=======================================
  Hits         4187     4187           
  Misses       2037     2037           
Flag Coverage Δ
python-integration 54.20% <ø> (ø)
python-unit 48.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pingsutw pingsutw merged commit dbcf369 into apache:master Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants