This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-332. Fix submarine server database connection failure #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingsutw
reviewed
Jan 4, 2020
bin/common.sh
Outdated
| if type wget >/dev/null 2>&1; then | ||
| wget ${MYSQL_JAR_URL} -P "${BIN}/../lib" --no-check-certificate | ||
| elif type curl >/dev/null 2>&1; then | ||
| curl -o "${BIN}/../lib/mysql-connector-java-${MYSQL_VERSION}.jar" ${MYSQL_JAR_URL} |
Member
There was a problem hiding this comment.
Could we use "${SUBMARINE_HOME}/lib/mysql-connector-java-${MYSQL_VERSION}.jar"
Member
Author
There was a problem hiding this comment.
This is a good question.
But using the SUBMARINE_HOME variable, you must define the path in submarine-env.sh.
I think it may be easier to use SUBMARINE_HOME in the future.
Member
There was a problem hiding this comment.
SUBMARINE_HOME already define in common.sh
Line 30 in 7576a5e
Member
Author
There was a problem hiding this comment.
Okay, thanks for your reminder.
Member
|
Thanks @liuxunorg for the contribution, LGTM |
Member
Author
|
@pingsutw Thank you help me review code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The submarine server cannot access the database due to the following issues
submairne-site.xml.What type of PR is it?
[Bug Fix | Improvement ]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: