Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-364. Fix copying submarine-dist.tar.gz error in build_mini-submarine.sh#167

Closed
xunliu wants to merge 1 commit intoapache:masterfrom
xunliu:SUBMARINE-364
Closed

SUBMARINE-364. Fix copying submarine-dist.tar.gz error in build_mini-submarine.sh#167
xunliu wants to merge 1 commit intoapache:masterfrom
xunliu:SUBMARINE-364

Conversation

@xunliu
Copy link
Copy Markdown
Member

@xunliu xunliu commented Jan 28, 2020

What is this PR for?

Error copying submarine-dist.tar.gz in build_mini-submarine.sh

What type of PR is it?

[Bug Fix]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Copy Markdown
Member

@jiwq jiwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @liuxunorg for the contribution.

@xunliu
Copy link
Copy Markdown
Member Author

xunliu commented Jan 28, 2020

@jiwq Thank you help review this PR.
Will merge if no more comments.

@yuanzac
Copy link
Copy Markdown
Contributor

yuanzac commented Jan 29, 2020

LGTM,
Thanks @liuxunorg & @jiwq

@asfgit asfgit closed this in 4d0bd20 Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants