Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-371. Remove tony submodule.#173

Closed
yuanzac wants to merge 1 commit intoapache:masterfrom
yuanzac:topic/SUBMARINE-371
Closed

SUBMARINE-371. Remove tony submodule.#173
yuanzac wants to merge 1 commit intoapache:masterfrom
yuanzac:topic/SUBMARINE-371

Conversation

@yuanzac
Copy link
Copy Markdown
Contributor

@yuanzac yuanzac commented Feb 6, 2020

What is this PR for?

To work with tony community more closely, we need to remove tony submodule and use tony dependency directly. We should not maintain tony code by ourselves. If a patch to tony is needed, we should submit a PR to tony repository

What type of PR is it?

Improvement

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-371

How should this be tested?

https://travis-ci.org/yuanzac/hadoop-submarine/builds/646704729?utm_source=github_status&utm_medium=notification

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? Yes

Copy link
Copy Markdown
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Member

@jiwq jiwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit closed this in 82fae82 Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants