Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

Conversation

@jiwq
Copy link
Member

@jiwq jiwq commented Feb 10, 2020

What is this PR for?

To reduce growth of the indentation mess

What type of PR is it?

[Improvement]

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-384

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Contributor

@yuanzac yuanzac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiwq,
Thanks for the contributions~

Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this EditorConfig file, what settings need to be set in the development tool (e.g., IDEA)?

@pingsutw
Copy link
Member

There is an EditConfig file in submarine-workbench/workbench-web/.editorconfig, Do we need to combine to this config (./submarine/.editorconfig)

@jiwq
Copy link
Member Author

jiwq commented Feb 12, 2020

With this EditorConfig file, what settings need to be set in the development tool (e.g., IDEA)?

Hi @liuxunorg, high-frequency IDEs(IDEA/PyCharm/WebStorm/VisualStudio and so on) come bundled with native support for EditorConfig. So the user do not need extra work. More info see here.

@jiwq
Copy link
Member Author

jiwq commented Feb 12, 2020

There is an EditConfig file in submarine-workbench/workbench-web/.editorconfig, Do we need to combine to this config (./submarine/.editorconfig)

@pingsutw Thanks for your focus, I think it's not conflicted. On the contrary, the subproject should better own itself EditorConfig. Any thoughts?

@pingsutw
Copy link
Member

Okay. If it's not conflicted, I thought we don't need to change it.
Thanks @jiwq. LGTM

@asfgit asfgit closed this in e3b5c5c Feb 13, 2020
@jiwq jiwq deleted the SUBMARINE-384 branch February 13, 2020 02:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants