This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-402. Add tutorial for adding test cases and browsers to e2e with Angular#201
Closed
cchung100m wants to merge 1 commit intoapache:masterfrom
Closed
SUBMARINE-402. Add tutorial for adding test cases and browsers to e2e with Angular#201cchung100m wants to merge 1 commit intoapache:masterfrom
cchung100m wants to merge 1 commit intoapache:masterfrom
Conversation
cchung100m
changed the title
kevin85421
reviewed
Mar 4, 2020
Member
kevin85421
left a comment
kevin85421
left a comment
There was a problem hiding this comment.
@cchung100m Thank you for your contribution! The pull request looks good to me, and I believe that it is ready to be merged.
xunliu
approved these changes
Mar 5, 2020
Member
xunliu
left a comment
xunliu
left a comment
There was a problem hiding this comment.
Will merge if no more comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @kevin85421
Following our discussion in #197, This PR is going to add the tutorial for the test cases adding and browsers configuration. I would appreciate if you can help to review it, thanks.
What is this PR for?
Add tutorial for adding test cases and browsers to e2e with Angular
What type of PR is it?
Documentation
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-402
How should this be tested?
https://travis-ci.com/cchung100m/submarine/builds/151553436
Questions: