This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-79. Solve potential NPE for MockRemoteDirectoryManager#223
Closed
cchung100m wants to merge 1 commit intoapache:masterfrom
Closed
SUBMARINE-79. Solve potential NPE for MockRemoteDirectoryManager#223cchung100m wants to merge 1 commit intoapache:masterfrom
cchung100m wants to merge 1 commit intoapache:masterfrom
Conversation
cchung100m
force-pushed
the
SUBMARINE-79
branch
from
849559b to
f66faee
Compare
Author
|
@liuxunorg Thanks for managing this PR. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Solve potential NPE for MockRemoteDirectoryManager
MockRemoteDirectoryManager#getModelDir:
File modelDir = new File(modelParentDir.getAbsolutePath(), modelName);If modelParentDir is null, we could have an NPE easily.
What type of PR is it?
[Bug Fix | Improvement ]
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-79
How should this be tested?
https://travis-ci.com/cchung100m/submarine/builds/152619875
Screenshots (if appropriate)
Questions: