Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-513. Remove "\n" in job logs#297

Closed
JohnTing wants to merge 2 commits intoapache:masterfrom
JohnTing:SUBMARINE-513
Closed

SUBMARINE-513. Remove "\n" in job logs#297
JohnTing wants to merge 2 commits intoapache:masterfrom
JohnTing:SUBMARINE-513

Conversation

@JohnTing
Copy link
Copy Markdown
Contributor

@JohnTing JohnTing commented May 24, 2020

What is this PR for?

When logging job output, the content contains "\n", didn't print correctly.

curl -X GET http://127.0.0.1:8080/api/v1/jobs/logs/job_1590165277436_0001

What type of PR is it?

Improvement

Todos

  • [X ] - Task

What is the Jira issue?

https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-513

How should this be tested?

Screenshots (if appropriate)

image

Questions:

  • Does the licenses files need update? Yes/No
  • Is there breaking changes for older versions? Yes/No
  • Does this needs documentation? Yes/No

@xunliu
Copy link
Copy Markdown
Member

xunliu commented May 25, 2020

@JohnTing Thank you fixed this problem.

What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]

Please select a type.

@tangzhankun
Copy link
Copy Markdown
Contributor

@JohnTing Thanks for the contribution. It looks good to me. The only concern is when the log data size is huge in some extreme cases, we may crash the submarine server. But I'm ok with the current implementation before we have a better log solution. Will get this in soon.

@asfgit asfgit closed this in 69f3a0f May 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants