This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-524. Add travis test of commons-unixusersync#309
Closed
Eroschang wants to merge 5 commits intoapache:masterfrom
Closed
SUBMARINE-524. Add travis test of commons-unixusersync#309Eroschang wants to merge 5 commits intoapache:masterfrom
Eroschang wants to merge 5 commits intoapache:masterfrom
Conversation
Contributor
|
@Eroschang Thanks for the contribution. One doubt, why the commons-unixusersync only have test cases now? Do we need nny other utilities of LDAP APIs? |
xunliu
changed the title
Member
Because synchronous ldap can be achieved through the ranger's exist modules, We have implemented the function first in this way, and we can easily adjust it when the requirements are clarified later. |
xunliu
approved these changes
Jun 16, 2020
Member
xunliu
left a comment
xunliu
left a comment
There was a problem hiding this comment.
LGTM
Will merge if no more comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
To test the module of commons-unixusersync.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-524
How should this be tested?
https://travis-ci.org/github/Eroschang/submarine
Screenshots (if appropriate)
Questions: