This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-552. [WEB]Implement experiment information charts page#338
Closed
kobe860219 wants to merge 1 commit into
Closed
SUBMARINE-552. [WEB]Implement experiment information charts page#338kobe860219 wants to merge 1 commit into
kobe860219 wants to merge 1 commit into
Conversation
Contributor
Author
lleohao
approved these changes
Jul 2, 2020
xunliu
approved these changes
Jul 2, 2020
Member
xunliu
left a comment
xunliu
left a comment
There was a problem hiding this comment.
@kobe860219 coooool !!!
Thank you contribution this feature. very nice!
@lleohao Thank you for helping review the PR! thanks
jiwq
approved these changes
Jul 2, 2020
xunliu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
1.Import swimlane/ngx-charts module with version 13.0.1 .
2.Implement experiment information charts page with simulated data for testing swimlane/ngx-charts.
What type of PR is it?
[Feature]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-552
How should this be tested?
https://travis-ci.org/github/kobe860219/submarine
Screenshots (if appropriate)
Questions: