This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-566. [WEB] Create a new experiment through UI#354
Closed
wang0630 wants to merge 4 commits intoapache:masterfrom
Closed
SUBMARINE-566. [WEB] Create a new experiment through UI#354wang0630 wants to merge 4 commits intoapache:masterfrom
wang0630 wants to merge 4 commits intoapache:masterfrom
Conversation
wang0630
changed the title
pingsutw
changed the title
wang0630
force-pushed
the
SUBMARINE-566
branch
6 times, most recently
from
6b19f2d to
43fd6a2
Compare
pingsutw
reviewed
Jul 25, 2020
Member
pingsutw
left a comment
pingsutw
left a comment
There was a problem hiding this comment.
The test failure is unrelated to it.
@liuxunorg @kobe860219 @kevin85421 Could you also take a look at it.
submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/experimentNewIT.java
Outdated
Show resolved
Hide resolved
submarine-workbench/workbench-web-ng/src/app/services/base-api.service.ts
Outdated
Show resolved
Hide resolved
Now experiment creation through UI is possible, however more user-feedback warning meesages will be added later. In addition, integration test is refactored to follow DRY principle, avoiding specifing the same By selector repeatedly. Page objects are put in integration/pages to do all the heavy work, while experimentIT will contain the basic assertion and flow only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
New experiment creation through UI.
What type of PR is it
[Feature]
Todos
What is the Jira issue?
SUBMARINE-566
How should this be tested?
https://travis-ci.com/github/wang0630/submarine/jobs/364539196
Screenshots (if appropriate)
Questions: