Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-602. [WEB] Fix some bugs in workspace page#380

Closed
kevin85421 wants to merge 1 commit intoapache:masterfrom
kevin85421:SUBMARINE-602
Closed

SUBMARINE-602. [WEB] Fix some bugs in workspace page#380
kevin85421 wants to merge 1 commit intoapache:masterfrom
kevin85421:SUBMARINE-602

Conversation

@kevin85421
Copy link
Copy Markdown
Member

@kevin85421 kevin85421 commented Aug 18, 2020

What is this PR for?

Fix some bugs in workspace page

  1. Remove the unknown white block

attachment_1

2. (1) Implement the function of "click close icon" (2) Move the next step button

attachment_2

3. Move the previous button and next button

attachment_3

4. Move the previous button, save button and notebook button

attachment_4

What type of PR is it?

[Bug Fix]

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-602

How should this be tested?

https://travis-ci.org/github/kevin85421/hadoop-submarine

Screenshots (if appropriate)

SUBMARINE-602

Updated screenshot
截圖 2020-08-20 下午11 59 03

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Copy Markdown
Member

@jiwq jiwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the information is not displayed completely. Could you help to fix it?

@kevin85421
Copy link
Copy Markdown
Member Author

@jiwq Thank you for your suggestion! Can you explain the meaning of information further? Do you mean the "initial project" and "preview project" pages? Thanks!

@jiwq
Copy link
Copy Markdown
Member

jiwq commented Aug 18, 2020

@jiwq Thank you for your suggestion! Can you explain the meaning of information further? Do you mean the "initial project" and "preview project" pages? Thanks!

In create new project, it has three steps. The first step is Basic Information, in here I saw this issue.

Copy link
Copy Markdown
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevin85421 thanks for fixing this bug.

image
The "n" is not displayed completely

@kevin85421
Copy link
Copy Markdown
Member Author

@pingsutw Thanks! I will fix it soon.

@kevin85421
Copy link
Copy Markdown
Member Author

@pingsutw @jiwq I have fixed the problem. Thanks!

@pingsutw
Copy link
Copy Markdown
Member

Thanks @kevin85421, will merge if no more comment.

@asfgit asfgit closed this in 488ee3f Aug 22, 2020
@jiwq
Copy link
Copy Markdown
Member

jiwq commented Aug 22, 2020

Thanks @kevin85421 for the contribution and @pingsutw for the review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants