Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-586. Add the get/delete api & tests.#384

Closed
lowc1012 wants to merge 2 commits intoapache:masterfrom
lowc1012:SUBMARINE-586
Closed

SUBMARINE-586. Add the get/delete api & tests.#384
lowc1012 wants to merge 2 commits intoapache:masterfrom
lowc1012:SUBMARINE-586

Conversation

@lowc1012
Copy link
Copy Markdown
Contributor

@lowc1012 lowc1012 commented Aug 19, 2020

What is this PR for?

User can get/delete notebook instances with REST API
GET request to the URI (/api/v1/notebook/{id}) could get detailed info about the notebook with the notebook ID.
DELETE request to the URI (/api/v1/notebook/{id}) could delete the notebook instance with the notebook ID

What type of PR is it?

[Feature]

Todos

  • - Task

What is the Jira issue?

SUBMARINE-586

How should this be tested?

travis CI

Screenshots (if appropriate)

螢幕快照 2020-08-22 下午2 11 39

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Copy Markdown
Member

@jiwq jiwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks @lowc1012 for the contribution. Will commit if no more comments.

Copy link
Copy Markdown
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lowc1012 for the contribution.
one question, why dockerImage, kernelSpec, image are null?

@lowc1012
Copy link
Copy Markdown
Contributor Author

@jiwq Thank you for your review!
@pingsutw I updated the JSON response. Please review it again. Thanks a lot!

Copy link
Copy Markdown
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lowc1012, The update looks good to me.

@asfgit asfgit closed this in d65ed1a Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants