Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-601. Notebook API docs#385

Closed
lowc1012 wants to merge 2 commits intoapache:masterfrom
lowc1012:SUBMARINE-601
Closed

SUBMARINE-601. Notebook API docs#385
lowc1012 wants to merge 2 commits intoapache:masterfrom
lowc1012:SUBMARINE-601

Conversation

@lowc1012
Copy link
Copy Markdown
Contributor

What is this PR for?

Write a Notebook API docs into docs/userdocs/k8s/api

What type of PR is it?

[Documentation]

Todos

  • - Task

What is the Jira issue?

SUBMARINE-601

How should this be tested?

travis CI

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Copy Markdown
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lowc1012 for the contribution.
I think we should also add delete and patch notebook.

@lowc1012
Copy link
Copy Markdown
Contributor Author

Hi, @pingsutw @jiwq Thank you for your reviews!
We doesn't support update in the short term.
Because update a notebook requires restart of notebook, lost of ongoing work

@jiwq
Copy link
Copy Markdown
Member

jiwq commented Aug 22, 2020

+1 Will comment if no more comments.

@pingsutw
Copy link
Copy Markdown
Member

+1, LGTM

@asfgit asfgit closed this in a4b8b94 Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants