SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image#407
SUBMARINE-617. Update the apache/notebook:jupyter-notebook docker image#407lowc1012 wants to merge 5 commits intoapache:masterfrom
Conversation
|
I' m working on that inject submarine server DNS into notebook to easy the internal communication and SDK initialization. Please do not commit it temporarily. Thanks. |
|
In the first commit, apache-submarine package will be installed whenever creating notebook server. It spend a lot of time. I suggest that apache-submarine package should be installed before notebook container was running, and spend a lot of time pulling image when creating notebook server first time inevitably. |
|
Could you also set the environment used by Jupyter Notebook in https://github.com/apache/submarine/blob/master/docs/database/submarine-data.sql? |
|
@pingsutw Thanks for your review! I pushed a fixed-commit. |
What is this PR for?
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
SUBMARINE-617
How should this be tested?
Travis CI
Screenshots (if appropriate)
Questions: