This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-641. Auto convert experiment name to lowercase#422
Closed
aeioulisa wants to merge 4 commits intoapache:masterfrom
Closed
SUBMARINE-641. Auto convert experiment name to lowercase#422aeioulisa wants to merge 4 commits intoapache:masterfrom
aeioulisa wants to merge 4 commits intoapache:masterfrom
Conversation
xunliu
reviewed
Oct 1, 2020
...e-server/server-core/src/main/java/org/apache/submarine/server/notebook/NotebookManager.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Auto convert experiment name to lowercase cause k8s don't support name contains uppercase characters
contain no more than 253 characters
contain only lowercase alphanumeric characters, '-' or '.'
start with an alphanumeric character
end with an alphanumeric character
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-641
How should this be tested?
https://travis-ci.org/github/aeioulisa/submarine/builds/731539436
Screenshots (if appropriate)
Questions: