Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-675. Sync the status of notebook#468

Closed
lowc1012 wants to merge 3 commits intoapache:masterfrom
lowc1012:SUBMARINE-675
Closed

SUBMARINE-675. Sync the status of notebook#468
lowc1012 wants to merge 3 commits intoapache:masterfrom
lowc1012:SUBMARINE-675

Conversation

@lowc1012
Copy link
Copy Markdown
Contributor

@lowc1012 lowc1012 commented Dec 2, 2020

What is this PR for?

  1. The notebook REST api will return four states of notebook (creating/waiting/running/terminating) and its reason.
  • creating : Users submitted the request to create notebook and its pod haven't been created.
  • waiting : Still running the operations it requires in order to complete start up: for example, pulling the container image.
  • running : The container is executing without issues and readyReplicas equals to 1
  • terminating : Users submitted the request to delete notebook
  1. Refactoring K8sSubmitter
  2. Update userdocs/k8s/api/notebook.md

What type of PR is it?

[Improvement | Documentation | Refactoring]

Todos

  • [@kobe860219 ] - Front-end : Using RxJS to do polling the status of notebook instance and adding spinner when notebook status is creating/waiting.

What is the Jira issue?

SUBMARINE-675

How should this be tested?

Travis CI

Screenshots (if appropriate)

image

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

}
}
' http://127.0.0.1:8080/api/v1/notebook
' http://127.0.0.1:32080/api/v1/notebook
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change the service port?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we deploy Traefik as default ingress controller in Submarine and it exposed with nodePort (32080)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lowc1012 Traefik port, can it be fixed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fixed for port 32080 if we use 'helm install' command. We can enable submarine expose another port by modified the parameter.

@jiwq
Copy link
Copy Markdown
Member

jiwq commented Dec 8, 2020

+1 Will merge if no more comments. Thanks @lowc1012 for the contribution.

@asfgit asfgit closed this in d104080 Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants