This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-675. Sync the status of notebook#468
Closed
lowc1012 wants to merge 3 commits intoapache:masterfrom
Closed
SUBMARINE-675. Sync the status of notebook#468lowc1012 wants to merge 3 commits intoapache:masterfrom
lowc1012 wants to merge 3 commits intoapache:masterfrom
Conversation
jiwq
reviewed
Dec 2, 2020
| } | ||
| } | ||
| ' http://127.0.0.1:8080/api/v1/notebook | ||
| ' http://127.0.0.1:32080/api/v1/notebook |
Contributor
Author
There was a problem hiding this comment.
Because we deploy Traefik as default ingress controller in Submarine and it exposed with nodePort (32080)
Contributor
Author
There was a problem hiding this comment.
It is fixed for port 32080 if we use 'helm install' command. We can enable submarine expose another port by modified the parameter.
...ubmitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/util/NotebookUtils.java
Outdated
Show resolved
Hide resolved
Member
|
+1 Will merge if no more comments. Thanks @lowc1012 for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
What type of PR is it?
[Improvement | Documentation | Refactoring]
Todos
What is the Jira issue?
SUBMARINE-675
How should this be tested?
Travis CI
Screenshots (if appropriate)
Questions: