This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-693. Sync the status of notebook on workbench web#482
Closed
kobe860219 wants to merge 6 commits intoapache:masterfrom
Closed
SUBMARINE-693. Sync the status of notebook on workbench web#482kobe860219 wants to merge 6 commits intoapache:masterfrom
kobe860219 wants to merge 6 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@lowc1012 Please help review this PR. Thanks ! |
lowc1012
reviewed
Dec 27, 2020
| return this.poller; | ||
| } | ||
|
|
||
| private iterate() { |
Contributor
There was a problem hiding this comment.
Please adjust indents to the same format.
jiwq
reviewed
Dec 27, 2020
Member
jiwq
left a comment
jiwq
left a comment
There was a problem hiding this comment.
Should format the new code to keep the same code style.
| public getPoller() { | ||
| return this.poller; | ||
| } | ||
| } No newline at end of file |
Member
|
+1 Thanks @kobe860219 for the contribution and @lowc1012 for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This improvement make workbench web could sync status of notebooks. It's make UI more friendly for users.
The pr is related of SUBMARINE-675
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
SUBMARINE-693
How should this be tested?
Travis CI
Screenshots (if appropriate)
Questions: