This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-638. [Spark-Security]Apply global/local limit after masking projection#490
Closed
harsha-tenneti wants to merge 1 commit intoapache:masterfrom
Closed
SUBMARINE-638. [Spark-Security]Apply global/local limit after masking projection#490harsha-tenneti wants to merge 1 commit intoapache:masterfrom
harsha-tenneti wants to merge 1 commit intoapache:masterfrom
Conversation
harsha-tenneti
changed the title
harsha-tenneti
changed the title
Author
|
@yaooqinn can you please help look at this PR |
yaooqinn
reviewed
Jan 15, 2021
| // Extract global/local limit if any and apply after masking projection | ||
| val limitExpr: Option[Expression] = plan match { | ||
| case unaryNode: UnaryNode => | ||
| unaryNode match { |
harsha-tenneti
force-pushed
the
SUBMARINE-638
branch
from
9a9a93c to
c2997f6
Compare
yaooqinn
approved these changes
Jan 15, 2021
Member
Member
|
LGTM |
Member
|
thanks~ merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR optimises the limit query when masking policies are applied in the spark-security plugin. This is applying the global limit on top masking projection if there is a limit in the initial plan
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-638
How should this be tested?
https://travis-ci.org/github/harsha-tenneti/submarine/builds/754430620
Screenshots (if appropriate)
Questions: