Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-710. Frontend support for tensorboard#492

Closed
ByronHsu wants to merge 4 commits intoapache:masterfrom
ByronHsu:SUBMARINE-710
Closed

SUBMARINE-710. Frontend support for tensorboard#492
ByronHsu wants to merge 4 commits intoapache:masterfrom
ByronHsu:SUBMARINE-710

Conversation

@ByronHsu
Copy link
Copy Markdown
Member

@ByronHsu ByronHsu commented Jan 14, 2021

What is this PR for?

I created a "tensorboard" button on the experiment page in the workbench.
It will show as loading when

  1. the api-client is still fetching the tensorboard meta-data
  2. tensorboard pod is not ready

After the fetching succeeds, users can click the button and link to the tensorboard page.

What type of PR is it?

[Feature]

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-710

How should this be tested?

Screenshots (if appropriate)

Kapture 2021-01-14 at 20 52 31

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@ByronHsu
Copy link
Copy Markdown
Member Author

@kevin85421 @pingsutw Help me review this PR. Thanks!

Copy link
Copy Markdown
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ByronHsu Thanks for your contribution.

Copy link
Copy Markdown
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in a2c1e59 Jan 19, 2021
@ByronHsu ByronHsu deleted the SUBMARINE-710 branch May 3, 2021 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants