This repository was archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-708. Add mailing list subscription link#499
Closed
aeioulisa wants to merge 4 commits intoapache:masterfrom
Closed
SUBMARINE-708. Add mailing list subscription link#499aeioulisa wants to merge 4 commits intoapache:masterfrom
aeioulisa wants to merge 4 commits intoapache:masterfrom
Conversation
cxorm
reviewed
Jan 26, 2021
Member
cxorm
left a comment
cxorm
left a comment
There was a problem hiding this comment.
Thanks @aeioulisa for the work.
Overall LGTM, one question inlined.
cxorm
approved these changes
Jan 26, 2021
Member
cxorm
left a comment
cxorm
left a comment
There was a problem hiding this comment.
Thank you @aeioulisa for the fix.
I'm +1 for it.
Member
|
Hi @pingsutw, |
lowc1012
reviewed
Jan 26, 2021
lowc1012
suggested changes
Jan 26, 2021
lowc1012
approved these changes
Jan 26, 2021
Contributor
lowc1012
left a comment
lowc1012
left a comment
There was a problem hiding this comment.
LGTM. @aeioulisa Thanks!
xunliu
approved these changes
Jan 27, 2021
Member
xunliu
left a comment
xunliu
left a comment
There was a problem hiding this comment.
@aeioulisa Thank you for contributions.
Will merge if no more comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add mailing list subscription link in Readme
What type of PR is it?
[Documentation]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-708
How should this be tested?
Screenshots (if appropriate)
Questions: